Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename RemoveConstIgnore to RemoveLoadConstant #767

Closed
ss2165 opened this issue Jan 3, 2024 · 0 comments · Fixed by #789
Closed

Rename RemoveConstIgnore to RemoveLoadConstant #767

ss2165 opened this issue Jan 3, 2024 · 0 comments · Fixed by #789
Assignees
@aborgna-q
Labels
spec Issues to do with the specification document(s)
Milestone
v0.1.0

Comments

@ss2165
Copy link
Member

ss2165 commented Jan 3, 2024 

          We should really rename this to `RemoveLoadConstant` rather than this "ignore" malarky?

Originally posted by @acl-cqc in #757 (comment)
@ss2165 ss2165 added the spec Issues to do with the specification document(s) label Jan 3, 2024
@ss2165 ss2165 mentioned this issue Jan 3, 2024
Merged
@ss2165 ss2165 added this to the v0.1.0 milestone Jan 4, 2024
@aborgna-q aborgna-q self-assigned this Jan 8, 2024
@aborgna-q aborgna-q mentioned this issue Jan 8, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 8, 2024
@aborgna-q
refactor!: s/RemoveConstIgnore/RemoveLoadConstant (#789)
25d03aa 
Renames the rewrite to better reflect it's goal.

Closes #767
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborgna-q aborgna-q

Labels
spec Issues to do with the specification document(s)
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging a pull request may close this issue.

refactor!: s/RemoveConstIgnore/RemoveLoadConstant CQCL/hugr
2 participants
@ss2165 @aborgna-q