Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case nodes have unconnected ports #750

Closed
ss2165 opened this issue Dec 18, 2023 · 0 comments · Fixed by #749
Closed

Case nodes have unconnected ports #750

ss2165 opened this issue Dec 18, 2023 · 0 comments · Fixed by #749
Labels
bug Something isn't working

Comments

@ss2165
Copy link
Member

ss2165 commented Dec 18, 2023

as identified by @mark-koch

The serialized hugr in this file:
graph (1).hugr.zip

fails validation when deserialized because case nodes are reporting that they have unconnected ports (they shouldn't have any)

@ss2165 ss2165 added the bug Something isn't working label Dec 18, 2023
github-merge-queue bot pushed a commit that referenced this issue Dec 20, 2023
Previously it was incorrectly reporting the internal signature as the
node signature.

Fixes #750 

Required further fixes to `replace.rs`:
* test was looking for an error that should have been hidden behind
another (that was not previously reported because of #750). Look for the
latter, not the former.
* Fix node indices not being correctly reported from `apply`

---------

Co-authored-by: Alan Lawrence <[email protected]>
ss2165 added a commit that referenced this issue Dec 21, 2023
Previously it was incorrectly reporting the internal signature as the
node signature.

Fixes #750 

Required further fixes to `replace.rs`:
* test was looking for an error that should have been hidden behind
another (that was not previously reported because of #750). Look for the
latter, not the former.
* Fix node indices not being correctly reported from `apply`

---------

Co-authored-by: Alan Lawrence <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant