Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make OpaqueOp::signature non-optional. #689

Closed
aborgna-q opened this issue Nov 14, 2023 · 0 comments · Fixed by #732
Closed

Make OpaqueOp::signature non-optional. #689

aborgna-q opened this issue Nov 14, 2023 · 0 comments · Fixed by #732
Assignees
Labels
bug Something isn't working

Comments

@aborgna-q
Copy link
Collaborator

aborgna-q commented Nov 14, 2023

Currently it's an optional field as an optimisation for the serial format, where we could avoid encoding some signatures if we know the relevant extension will be available at load-time.

However, the current deserialiser does not support this and just fails.

We should temporarily drop this optimisation, at least until we can pass extension registers to the deserialiser.

This (plus #690) is the root cause of #683.

@aborgna-q aborgna-q added the bug Something isn't working label Nov 14, 2023
@aborgna-q aborgna-q self-assigned this Dec 1, 2023
github-merge-queue bot pushed a commit that referenced this issue Dec 1, 2023
Closes #689 

Adds a previously-failing test for the serialiser, where the signature
of an opaque op was discarded and couldn't be recovered. Depends on
#730.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant