Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert binary compute_signatures to type schemes #658

Closed
Tracked by #416
acl-cqc opened this issue Nov 8, 2023 · 0 comments · Fixed by #678
Closed
Tracked by #416

Convert binary compute_signatures to type schemes #658

acl-cqc opened this issue Nov 8, 2023 · 0 comments · Fixed by #678
Assignees
@ss2165

Comments

@acl-cqc
Copy link
Contributor

acl-cqc commented Nov 8, 2023 •
edited
Loading

After #630 is merged, many existing Rust/binary implementations of compute_signature can be converted to a type scheme using a PolyFuncType
@ss2165 ss2165 self-assigned this Nov 9, 2023
This was referenced Nov 9, 2023
Closed
Merged
github-merge-queue bot pushed a commit that referenced this issue Nov 13, 2023
@ss2165
refactor: use type schemes in extension definitions wherever possible (…
201d1a2 
…#678)

Closes #658 

As a drive by improve extensions test coverage as I went.

Definition can be a bit unintuitive, should improve after #676 is done.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ss2165 ss2165

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: use type schemes in extension definitions wherever possible CQCL/hugr
2 participants
@ss2165 @acl-cqc