Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix variable instantiation in extension inference #598

Closed
croyzor opened this issue Oct 11, 2023 · 0 comments · Fixed by #591
Closed

Fix variable instantiation in extension inference #598

croyzor opened this issue Oct 11, 2023 · 0 comments · Fixed by #591
Assignees
@croyzor

Comments

@croyzor
Copy link
Contributor

croyzor commented Oct 11, 2023

Code has been implemented to find a minimum extension solution for metavariables which loop into themselves, but we can also arrive at the state during this phase of unification where we end up with multiple variables which form a loop, which should be treated similarly. Currently, when we reach this condition an error is thrown.
@croyzor croyzor self-assigned this Oct 11, 2023
@croyzor croyzor mentioned this issue Oct 11, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Nov 8, 2023
@croyzor @acl-cqc
fix(Inference): Work harder in variable instantiation (#591)
2269161 
Extend the `instantiate_variables` method in extension inference to
handle the case where we end up with variables which form loops of
`Plus` constraints with other metavariables. This is required to get the
rest of the test variants in `test_cfg_loops` to work

Resolves #598

---------

Co-authored-by: Alan Lawrence <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@croyzor croyzor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Inference): Work harder in variable instantiation CQCL/hugr
1 participant
@croyzor