Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SimpleReplacement should return weights of removed nodes. #476

Closed
ss2165 opened this issue Aug 31, 2023 · 1 comment · Fixed by #1516
Closed

SimpleReplacement should return weights of removed nodes. #476

ss2165 opened this issue Aug 31, 2023 · 1 comment · Fixed by #1516
Assignees
@ss2165
Labels
breaking-change Changes that break semver enhancement New feature or request
Milestone
hugr-rs 0.13.0 / ...

Comments

@ss2165
Copy link
Member

ss2165 commented Aug 31, 2023

Or maybe the whole removed subgraph?

Following on from #471
@ss2165 ss2165 added P-medium enhancement New feature or request labels Aug 31, 2023
@aborgna-q aborgna-q added the breaking-change Changes that break semver label Mar 14, 2024
@ss2165 ss2165 mentioned this issue Sep 3, 2024
Merged
@ss2165 ss2165 self-assigned this Sep 3, 2024
@ss2165 ss2165 added this to the hugr-rs 0.13.0 / hugr-py 0.9.0 milestone Sep 3, 2024
@ss2165 ss2165 mentioned this issue Sep 3, 2024
Merged
@ss2165
Copy link
Member Author

ss2165 commented Sep 9, 2024

Waiting for next breaking hugr release to merge

github-merge-queue bot pushed a commit that referenced this issue Oct 2, 2024
@ss2165
feat!: HugrMut::remove_node and SimpleReplacement return removed …
ea8e818 
…weights (#1516)

Closes #476 

BREAKING CHANGE: `remove_node` now returns an OpType, and the
`ApplyResult` of `SimpleReplacement` holds replaced nodes and weights.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ss2165 ss2165

Labels
breaking-change Changes that break semver enhancement New feature or request
Projects
None yet
Milestone
hugr-rs 0.13.0 / hugr-py 0.9.0
Development

Successfully merging a pull request may close this issue.

feat!: HugrMut::remove_node and SimpleReplacement return removed weights CQCL/hugr
2 participants
@ss2165 @aborgna-q