Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Predicate/SimplePredicate (to Choice + UnitChoice?) #448

Closed
ss2165 opened this issue Aug 23, 2023 · 0 comments · Fixed by #557
Closed

Rename Predicate/SimplePredicate (to Choice + UnitChoice?) #448

ss2165 opened this issue Aug 23, 2023 · 0 comments · Fixed by #557
Assignees
@ss2165

Comments

@ss2165
Copy link
Member

ss2165 commented Aug 23, 2023 •
edited
Loading

I was thinking the same (BoundedUSize) but I take your argument. Really I think "predicate" is the wrong word to start. We're calling it that because we use it to control branches, but IMHO predicate is inherently binary - true or false - Google gives me this:

LOGIC
something which is affirmed or denied concerning an argument of a proposition

So perhaps go with predicate for now but a better word might be "selector" or "choice"? or wilder ideas like "Nway"

Originally posted by @acl-cqc in #445 (comment)
@ss2165 ss2165 self-assigned this Sep 26, 2023
ss2165 added a commit that referenced this issue Sep 26, 2023
@ss2165
refactor!: rename predicate to choice
08bb5af 
Closes #448
@ss2165 ss2165 mentioned this issue Sep 26, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 23, 2023
@ss2165
refactor!: rename predicate to TupleSum/UnitSum (#557)
bb446e2 
Closes #448

BREAKING CHANGE: previous uses of type/value constructor methods for
"predicates" will need updating
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ss2165 ss2165

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor!: rename predicate to TupleSum/UnitSum CQCL/hugr
1 participant
@ss2165