Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store function name in Def/Declare nodes #136

Closed
ss2165 opened this issue Jun 8, 2023 Discussed in #72 · 0 comments · Fixed by #144
Closed

Store function name in Def/Declare nodes #136

ss2165 opened this issue Jun 8, 2023 Discussed in #72 · 0 comments · Fixed by #144
Assignees
@ss2165

Comments

@ss2165
Copy link
Member

ss2165 commented Jun 8, 2023

Discussed in #72

Originally posted by ss2165 May 19, 2023
@ss2165
16 May 2023

Linking happens by looking up functions by name - therefore it seems the name should not just be metadata (I don’t think linking should rely on metadata)

@ss2165
16 May 2023

I think this means that declare/alias_declare should hold names, and that these operations are only valid at module level.

@acl-cqc
16 May 2023

I’d be happy with that. The alternative would be - the metadata may contain data that affects other tools (that operate on the Hugr), right? So we just have to say that the linker is an”other tool”….

@acl-cqc
16 May 2023

Also, we will need some kind of namespacing on these names, right?
@ss2165 ss2165 self-assigned this Jun 8, 2023
ss2165 added a commit that referenced this issue Jun 9, 2023
@ss2165
Store function name in Def and Declare nodes
256556c 
Closes #136
@ss2165 ss2165 mentioned this issue Jun 9, 2023
Merged
ss2165 added a commit that referenced this issue Jun 9, 2023
@ss2165
Store function name in Def and Declare nodes (#144)
0fefde4 
Closes #136
ss2165 added a commit that referenced this issue Nov 21, 2024
@ss2165
fix: don't normalise half turns (#137)
c73f36b 
Closes #136

drive-by: cargo update (hugr 0.13.2)

I have tested the test in
quantinuum-dev/guppy-integration#19 now passes and the
example has expected behaviour with crz oracle.
ss2165 added a commit that referenced this issue Nov 22, 2024
@ss2165
fix: don't normalise half turns (#137)
6335712 
Closes #136

drive-by: cargo update (hugr 0.13.2)

I have tested the test in
quantinuum-dev/guppy-integration#19 now passes and the
example has expected behaviour with crz oracle.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ss2165 ss2165

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Store function name in Def and Declare nodes CQCL/hugr
1 participant
@ss2165