You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Closes#1241
Used to ensure `try_from_name` only succeeds when the extension is
correct
BREAKING CHANGE:
- `MakeOpDef` trait has new required `extension` method.
- `try_from_name` takes the OpDef extension and checks it
I am working with two ops:
when I have a
lazy.Measure
op thenTk2Op::try_from(op)
succeeds erroneously.This is because the
impl MakeOpDef for Tk2Op
hasThis function should check that the extension of
op_def
is correct.I am creating the issue here because I think the
simple_op.rs
machinery should take care of this, perhaps addingfn extension
toNamedOp
?The text was updated successfully, but these errors were encountered: