Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Value::Tuple #1206

Closed
doug-q opened this issue Jun 19, 2024 · 1 comment · Fixed by #1255
Closed

Remove Value::Tuple #1206

doug-q opened this issue Jun 19, 2024 · 1 comment · Fixed by #1255
Assignees
@ss2165

Comments

@doug-q
Copy link
Collaborator

doug-q commented Jun 19, 2024

Perhaps it makes sense to do this while sorting out #1091.

Docs for how to update serialisation schema are in progress in #985
@ss2165 ss2165 assigned ss2165 and unassigned ss2165 Jun 19, 2024
@ss2165
Copy link
Member

ss2165 commented Jun 20, 2024

Unclear whether it is worth actually removing it in the serialisation schema or just from the Rust and Python. It is a convenient shorthand for serialisation (like qubit, or unitsum)

@ss2165 ss2165 changed the title Remove Value::Tuple and it's representation in the serialisation schema Remove Value::Tuple Jun 27, 2024
@ss2165 ss2165 mentioned this issue Jul 2, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 3, 2024
@ss2165
refactor!: remove Value::Tuple (#1255)
b965202 
Closes #1206 

uses new serialisation intermediary to keep serialized Tuple backwards
compatibility

Snaps updated because a tuple-like sum always uses tuple display now

BREAKING CHANGE: `Value::Tuple` removed. `Value::Sum` now holds a
standalone struct `Sum`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ss2165 ss2165

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor!: remove Value::Tuple CQCL/hugr
2 participants
@ss2165 @doug-q