Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CFG nodes do not fail validation when their input ports do not match the input node of the entry block #1189

Closed
doug-q opened this issue Jun 12, 2024 · 0 comments · Fixed by #1229
Closed

CFG nodes do not fail validation when their input ports do not match the input node of the entry block #1189

doug-q opened this issue Jun 12, 2024 · 0 comments · Fixed by #1229
Assignees
@ss2165
Labels
bug Something isn't working

Comments

@doug-q
Copy link
Collaborator

doug-q commented Jun 12, 2024

see CQCL/guppylang#242 for an example
@ss2165 ss2165 added the bug Something isn't working label Jun 18, 2024
@ss2165 ss2165 self-assigned this Jun 19, 2024
ss2165 added a commit that referenced this issue Jun 26, 2024
@ss2165
fix: cfg not validating entry/exit types
9048c8b 
Closes #1189

Failing example generated using hugr-py
@ss2165 ss2165 mentioned this issue Jun 26, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 27, 2024
@ss2165
fix: cfg not validating entry/exit types (#1229)
c21753d 
Closes #1189

Failing example generated using hugr-py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ss2165 ss2165

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: cfg not validating entry/exit types CQCL/hugr
2 participants
@ss2165 @doug-q