Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add_constant in circuit builder #1163

Closed
aborgna-q opened this issue Jun 5, 2024 · 0 comments · Fixed by #1168
Closed

add_constant in circuit builder #1163

aborgna-q opened this issue Jun 5, 2024 · 0 comments · Fixed by #1168
Assignees
@aborgna-q
Labels
enhancement New feature or request

Comments

@aborgna-q
Copy link
Collaborator

Given a CircuitBuilder, it's not currently possible to define new constants to pass to parametric operations.

We should define a

pub fn add_constant(&mut self, value: impl Into<Value>) -> Wire;

similar to Dataflow::add_load_value.
@aborgna-q aborgna-q added the enhancement New feature or request label Jun 5, 2024
@aborgna-q aborgna-q self-assigned this Jun 5, 2024
@aborgna-q aborgna-q mentioned this issue Jun 6, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 7, 2024
@aborgna-q
feat: CircuitBuilder::add_constant (#1168)
15c3ea9 
Closes #1163.

~~Blocked by #1142.~~
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborgna-q aborgna-q

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: CircuitBuilder::add_constant CQCL/hugr
1 participant
@aborgna-q