fix: don't normalise half turns #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #136 drive-by: cargo update (hugr 0.13.2) I have tested the test inhttps://github.com/quantinuum-dev/guppy-integration/pull/19 now passes and the example has expected behaviour with crz oracle.
ss2165
requested review from
qartik and
doug-q
and removed request for
qartik
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
==========================================
- Coverage 85.02% 84.76% -0.26%
==========================================
Files 31 31
Lines 4327 4313 -14
Branches 4327 4313 -14
==========================================
- Hits 3679 3656 -23
- Misses 310 326 +16
+ Partials 338 331 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 23, 2024
## 🤖 New release * `hugr-llvm`: 0.6.0 -> 0.6.1 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.6.1](v0.6.0...v0.6.1) - 2024-10-23 ### Bug Fixes - don't normalise half turns ([#137](#137)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/).
ss2165
pushed a commit
to CQCL/hugr
that referenced
this pull request
Nov 22, 2024
* `hugr-llvm`: 0.6.0 -> 0.6.1 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> 2024-10-23 - don't normalise half turns ([#137](CQCL/hugr-llvm#137)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #136
drive-by: cargo update (hugr 0.13.2)
I have tested the test in https://github.com/CQCL-DEV/guppy-integration/pull/19 now passes and the example has expected behaviour with crz oracle.