feat: add boolean xor support #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implement with not and equality for now - can be replaced with op once CQCL/hugr#1418 is done
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #747 +/- ##
==========================================
- Coverage 93.00% 93.00% -0.01%
==========================================
Files 71 71
Lines 8151 8178 +27
==========================================
+ Hits 7581 7606 +25
- Misses 570 572 +2 ☔ View full report in Codecov by Sentry. |
mark-koch
approved these changes
Jan 3, 2025
guppylang/std/builtins.py
Outdated
| # TODO: Use hugr op once implemented: https://github.com/CQCL/hugr/issues/1418 | ||
| @guppy | ||
| def __xor__(self: bool, other: bool) -> bool: | ||
| return not (self == other) # noqa: SIM201 |
There was a problem hiding this comment.
We should definitely add a __ne__ implementation 😅
Raised an issue #750
Closes #750
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement with not and equality for now - can be replaced with op once CQCL/hugr#1418 is done
Closes #750