Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add string type #733

Merged
merged 7 commits into from
Dec 23, 2024
Merged

feat: Add string type #733

merged 7 commits into from
Dec 23, 2024

Conversation

tatiana-s
Copy link
Contributor

@tatiana-s tatiana-s commented Dec 18, 2024

Closes #695

(Pending hugr release including commit b05a419)

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.81%. Comparing base (0936580) to head (b809414).

Files with missing lines Patch % Lines
guppylang/tys/builtin.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #733      +/-   ##
==========================================
- Coverage   92.81%   92.81%   -0.01%     
==========================================
  Files          71       71              
  Lines        8159     8171      +12     
==========================================
+ Hits         7573     7584      +11     
- Misses        586      587       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tatiana-s tatiana-s marked this pull request as ready for review December 19, 2024 11:57
@tatiana-s tatiana-s requested a review from a team as a code owner December 19, 2024 11:57
@tatiana-s tatiana-s requested a review from croyzor December 19, 2024 11:57

@guppy(module)
def main(s: StringStruct) -> None:
StringStruct("Lorem Ipsum")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we create guppy strings from py(...) expressions? I'd like a test of that as well please!

Copy link
Collaborator

@croyzor croyzor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tatiana-s tatiana-s added this pull request to the merge queue Dec 23, 2024
Merged via the queue into main with commit aa9341b Dec 23, 2024
3 checks passed
@tatiana-s tatiana-s deleted the ts/strings branch December 23, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add string type
3 participants