-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add string type #733
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #733 +/- ##
==========================================
- Coverage 92.81% 92.81% -0.01%
==========================================
Files 71 71
Lines 8159 8171 +12
==========================================
+ Hits 7573 7584 +11
- Misses 586 587 +1 ☔ View full report in Codecov by Sentry. |
|
||
@guppy(module) | ||
def main(s: StringStruct) -> None: | ||
StringStruct("Lorem Ipsum") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we create guppy strings from py(...)
expressions? I'd like a test of that as well please!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #695
(Pending hugr release including commit b05a419)