-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Option type to standard library #696
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
from abc import ABC | ||
|
||
from hugr import Wire, ops | ||
from hugr import tys as ht | ||
from hugr import val as hv | ||
|
||
from guppylang.definition.custom import CustomCallCompiler, CustomInoutCallCompiler | ||
from guppylang.definition.value import CallReturnWires | ||
from guppylang.error import InternalGuppyError | ||
from guppylang.std._internal.compiler.prelude import build_unwrap | ||
from guppylang.tys.arg import TypeArg | ||
|
||
|
||
class OptionCompiler(CustomInoutCallCompiler, ABC): | ||
"""Abstract base class for compilers for `Option` methods.""" | ||
|
||
@property | ||
def option_ty(self) -> ht.Option: | ||
match self.type_args: | ||
case [TypeArg(ty)]: | ||
return ht.Option(ty.to_hugr()) | ||
case _: | ||
raise InternalGuppyError("Invalid type args for Option op") | ||
|
||
|
||
class OptionConstructor(OptionCompiler, CustomCallCompiler): | ||
"""Compiler for the `Option` constructors `none` and `some`.""" | ||
|
||
def __init__(self, tag: int): | ||
self.tag = tag | ||
|
||
def compile(self, args: list[Wire]) -> list[Wire]: | ||
return [self.builder.add_op(ops.Tag(self.tag, self.option_ty), *args)] | ||
|
||
|
||
class OptionTestCompiler(OptionCompiler): | ||
"""Compiler for the `Option.is_none` and `Option.is_none` methods.""" | ||
|
||
def __init__(self, tag: int): | ||
self.tag = tag | ||
|
||
def compile_with_inouts(self, args: list[Wire]) -> CallReturnWires: | ||
[opt] = args | ||
cond = self.builder.add_conditional(opt) | ||
for i in [0, 1]: | ||
with cond.add_case(i) as case: | ||
val = hv.TRUE if i == self.tag else hv.FALSE | ||
opt = case.add_op(ops.Tag(i, self.option_ty), *case.inputs()) | ||
case.set_outputs(case.load(val), opt) | ||
[res, opt] = cond.outputs() | ||
return CallReturnWires(regular_returns=[res], inout_returns=[opt]) | ||
|
||
|
||
class OptionUnwrapCompiler(OptionCompiler, CustomCallCompiler): | ||
"""Compiler for the `Option.unwrap` method.""" | ||
|
||
def compile(self, args: list[Wire]) -> list[Wire]: | ||
[opt] = args | ||
return list( | ||
build_unwrap(self.builder, opt, "Option.unwrap: value is `None`").outputs() | ||
) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
from collections.abc import Sequence | ||
from typing import Generic, no_type_check | ||
|
||
import hugr.tys as ht | ||
|
||
from guppylang.decorator import guppy | ||
from guppylang.error import InternalGuppyError | ||
from guppylang.std._internal.compiler.option import ( | ||
OptionConstructor, | ||
OptionTestCompiler, | ||
OptionUnwrapCompiler, | ||
) | ||
from guppylang.std.builtins import owned | ||
from guppylang.tys.arg import Argument, TypeArg | ||
from guppylang.tys.param import TypeParam | ||
|
||
|
||
def _option_to_hugr(args: Sequence[Argument]) -> ht.Type: | ||
match args: | ||
case [TypeArg(ty)]: | ||
return ht.Option(ty.to_hugr()) | ||
case _: | ||
raise InternalGuppyError("Invalid type args for Option") | ||
|
||
|
||
T = guppy.type_var("T", linear=True) | ||
|
||
|
||
@guppy.type(_option_to_hugr, params=[TypeParam(0, "T", can_be_linear=True)]) | ||
class Option(Generic[T]): # type: ignore[misc] | ||
"""Represents an optional value.""" | ||
|
||
@guppy.custom(OptionTestCompiler(0)) | ||
@no_type_check | ||
def is_none(self: "Option[T]") -> bool: | ||
"""Returns `True` if the option is a `none` value.""" | ||
|
||
@guppy.custom(OptionTestCompiler(1)) | ||
@no_type_check | ||
def is_some(self: "Option[T]") -> bool: | ||
"""Returns `True` if the option is a `some` value.""" | ||
|
||
@guppy.custom(OptionUnwrapCompiler()) | ||
@no_type_check | ||
def unwrap(self: "Option[T]" @ owned) -> T: | ||
"""Returns the contained `some` value, consuming `self`. | ||
|
||
Panics if the option is a `none` value. | ||
""" | ||
|
||
|
||
@guppy.custom(OptionConstructor(0)) | ||
@no_type_check | ||
def none() -> Option[T]: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I thought you wanted to go with "Nothing" to future-proof? Or is the plan to overload the |
||
"""Constructs a `none` optional value.""" | ||
|
||
|
||
@guppy.custom(OptionConstructor(1)) | ||
@no_type_check | ||
def some(value: T @ owned) -> Option[T]: | ||
"""Constructs a `some` optional value.""" |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
from guppylang.decorator import guppy | ||
from guppylang.module import GuppyModule | ||
from guppylang.std.option import Option, none, some | ||
|
||
|
||
def test_none(validate, run_int_fn): | ||
module = GuppyModule("test_range") | ||
module.load(Option, none) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. bit inconvenient to have to load these separately There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, but this is only an issue for explicit modules |
||
|
||
@guppy(module) | ||
def main() -> int: | ||
x: Option[int] = none() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is this annotation required or here for readability? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's required, we can't infer the type |
||
is_none = 10 if x.is_none() else 0 | ||
is_some = 1 if x.is_some() else 0 | ||
return is_none + is_some | ||
|
||
compiled = module.compile() | ||
validate(compiled) | ||
run_int_fn(compiled, expected=10) | ||
|
||
|
||
def test_some_unwrap(validate, run_int_fn): | ||
module = GuppyModule("test_range") | ||
module.load(Option, some) | ||
|
||
@guppy(module) | ||
def main() -> int: | ||
x: Option[int] = some(42) | ||
is_none = 1 if x.is_none() else 0 | ||
is_some = x.unwrap() if x.is_some() else 0 | ||
return is_none + is_some | ||
|
||
compiled = module.compile() | ||
validate(compiled) | ||
run_int_fn(compiled, expected=42) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
worth adding to the docstring to explain what this callable is