Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Check uv version #660

Merged
merged 2 commits into from
Nov 25, 2024
Merged

chore: Check uv version #660

merged 2 commits into from
Nov 25, 2024

Conversation

aborgna-q
Copy link
Collaborator

As requested by #648.
I'm not sure if this is too much noise to add for a simple check.

Closes #648

@aborgna-q aborgna-q requested a review from a team as a code owner November 21, 2024 10:16
@aborgna-q aborgna-q requested a review from qartik November 21, 2024 10:16
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.48%. Comparing base (b2d569b) to head (165e78f).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #660      +/-   ##
==========================================
+ Coverage   92.45%   92.48%   +0.02%     
==========================================
  Files          66       66              
  Lines        7465     7505      +40     
==========================================
+ Hits         6902     6941      +39     
- Misses        563      564       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

DEVELOPMENT.md Outdated
@@ -30,6 +30,7 @@ To setup the environment manually you will need:

- Just: [just.systems](https://just.systems/)
- uv `>=0.4.27`: [docs.astral.sh](https://docs.astral.sh/uv/getting-started/installation/)
* If you have an older manually installed `uv` version, you can upgrade it with `uv self update`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if this is mentioned, we don't really need the script. Though might be nice to add the minimum version required in this line.

@aborgna-q aborgna-q added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit f293beb Nov 25, 2024
3 checks passed
@aborgna-q aborgna-q deleted the ab/just-check-uv branch November 25, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manual setup fails since #598
3 participants