Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update expression checker to use new diagnostics #587

Merged
merged 2 commits into from
Nov 5, 2024
Merged

refactor: Update expression checker to use new diagnostics #587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf60207
fix: Use whole cell when storing source for functions in jupyter
mark-koch Oct 22, 2024
c56c7c8
feat: Update expression checker to use new diagnostics
mark-koch Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions examples/demo.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,13 +160,14 @@
"name": "stderr",
"output_type": "stream",
"text": [
"Guppy compilation failed. Error in file <In [6]>:6\n",
"Error: Operator not defined (at <In [6]>:6:11)\n",
" | \n",
"4 | def bad(x: int) -> int:\n",
"5 | # Try to add a tuple to an int\n",
"6 | return x + (x, x)\n",
" | ^^^^^^^^^^ Binary operator `+` not defined for `int` and `(int, int)`\n",
"\n",
"4: def bad(x: int) -> int:\n",
"5: # Try to add a tuple to an int\n",
"6: return x + (x, x)\n",
" ^^^^^^^^^^\n",
"GuppyTypeError: Binary operator `+` not defined for arguments of type `int` and `(int, int)`\n"
"Guppy compilation failed due to 1 previous error\n"
]
}
],
Expand Down
Loading
Loading