feat!: Allow linear data inside lists #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #531 +/- ##
==========================================
- Coverage 91.63% 91.57% -0.06%
==========================================
Files 59 59
Lines 6190 6161 -29
==========================================
- Hits 5672 5642 -30
- Misses 518 519 +1 ☔ View full report in Codecov by Sentry. |
mark-koch
commented
Oct 2, 2024
Comment on lines
-6
to
+7
| ^ | ||
| GuppyTypeError: Expected argument of type `?T -> ?T`, got `qubit @owned -> qubit` | ||
| ^^^^^^ | ||
| GuppyTypeError: Cannot instantiate non-linear type variable `T` in type `forall T. (T -> T) -> None` with linear type `qubit` |
There was a problem hiding this comment.
A side effect of the unification change is that we get a better error message here.
However, I think #487 still applies
ss2165
reviewed
Oct 2, 2024
guppylang/prelude/builtins.py
Outdated
|
|
||
| @guppy.hugr_op(unsupported_op("Length")) | ||
| def __len__(self: list[T]) -> int: ... | ||
| @guppy.hugr_op(unsupported_op("pop")) # TODO: check None and unwrap |
|
|
||
| @guppy.hugr_op(unsupported_op("Pop")) | ||
| def __next__(self: list[T]) -> tuple[T, list[T]]: ... | ||
| @guppy.hugr_op(unsupported_op("length")) # TODO: inout return in wrong order |
There was a problem hiding this comment.
is this ordering being resolved elsewhere?
There was a problem hiding this comment.
Actually turns out that the length op doesn't return the list at all! CQCL/hugr#1543
guppylang/prelude/builtins.py
Outdated
|
|
||
| @guppy.custom(checker=FailingChecker("Guppy lists are immutable")) | ||
| def remove(self: list[T], elt: T) -> None: ... | ||
| @guppy.hugr_op(unsupported_op("Pop")) |
There was a problem hiding this comment.
case difference between "pop" and "Pop" ?
ss2165
approved these changes
Oct 2, 2024
mark-koch
changed the title
This was referenced Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #530 and closes #524.
@ownedflags if one of the arguments is not linear (otherwise we couldn't unifyL @ownedwith any classical type). We'll need to revisit that once we have flags that can be put on classical types.BREAKING CHANGE: Unsupported list methods have been removed.