-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: cargo build validator in CI #468
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #468 +/- ##
==========================================
- Coverage 92.05% 91.94% -0.11%
==========================================
Files 55 58 +3
Lines 5714 5849 +135
==========================================
+ Hits 5260 5378 +118
- Misses 454 471 +17 ☔ View full report in Codecov by Sentry. |
78dd8a2
to
6cf790d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I had to fix run_int_fn somehow to cope with that it now receives a Package not a Hugr. However, this is very much not a complete fix - perhaps it is even, dare I say it, a hack - but I guess one might argue it works fine for the kinds of function for which we expect run_int_fn to work anyway.
Yes, I think this is fine for now
We should probably have an issue for this, nonetheless.
Feel free to create one 👍
I think I reasoned that anyone wanting However, the bigger issue that playing around here reveals - is that the type annotations here (i.e. in |
pytest previously skipped the validation tests if the validator was not built, leading to the situation in #468 where many tests were accidentally skipped in CI. Instead, fail the tests if the validator is not installed, but allow `pytest --no_validation` to skip them instead. The possibility of doing similar for execution tests (somewhat-silently skipped if `execute-llvm` isn't installed) is left for a later PR. --------- Co-authored-by: Kartik Singhal <[email protected]>
Many hugr-building tests are showing up as
s
== skipped after #455. We need tocargo build
the validator first.Also "fix" (perhaps hack)
run_int_fn
to extract the firstmodule
Hugr from the Package coming back from compilation.