Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support nat/int ↔ bool cast operations #459

Merged
merged 1 commit into from
Sep 9, 2024
Merged

feat: Support nat/int ↔ bool cast operations #459

merged 1 commit into from
Sep 9, 2024

Conversation

aborgna-q
Copy link
Collaborator

@aborgna-q aborgna-q requested a review from a team as a code owner September 5, 2024 16:11
@aborgna-q aborgna-q requested review from doug-q and removed request for a team September 5, 2024 16:11
@aborgna-q aborgna-q modified the milestone: guppylang 0.10.0 Sep 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.71429% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.05%. Comparing base (b02e0d0) to head (07802a8).

Files with missing lines Patch % Lines
guppylang/prelude/_internal/compiler/arithmetic.py 83.33% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #459      +/-   ##
==========================================
+ Coverage   91.89%   92.05%   +0.16%     
==========================================
  Files          55       55              
  Lines        5699     5714      +15     
==========================================
+ Hits         5237     5260      +23     
+ Misses        462      454       -8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

doug-q
doug-q reviewed Sep 6, 2024
View reviewed changes
Copy link
Contributor

@doug-q doug-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we need some tests. Happy to approve if those tests are somewhere else

@qartik
Copy link
Member

qartik commented Sep 6, 2024

This might help resolve #264 as well.

Question: Why use I to refer to int when Bool is fully spelled out in IToBool etc?

@aborgna-q
Copy link
Collaborator Author

Looks good, but we need some tests. Happy to approve if those tests are somewhere else

We do have tests! Before they emitted a black box (guppylang.unsupported). When I started emiting prelude operations the validation started failing on the ones that had the wrong signature vs what's declared in hugr's extension.

Question: Why use I to refer to int when Bool is fully spelled out in IToBool etc?

All the int-related operations start with i; iadd, ieq, ifromusize, ...

Base automatically changed from ab/update-hugr to main September 6, 2024 14:58
@aborgna-q aborgna-q requested a review from doug-q September 9, 2024 08:59
@aborgna-q aborgna-q added this pull request to the merge queue Sep 9, 2024
Merged via the queue into main with commit 3b778c3 Sep 9, 2024
3 checks passed
@aborgna-q aborgna-q deleted the ab/any-i-from-bool branch September 9, 2024 09:18
@aborgna-q aborgna-q mentioned this pull request Sep 11, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Sep 11, 2024
@hugrbot
chore(main): release 0.10.0 (#377)
4309059 
🤖 I have created a release *beep* *boop*
---


## [0.10.0](v0.9.0...v0.10.0)
(2024-09-11)


### ⚠ BREAKING CHANGES

* Bumped the `hugr` dependency to `0.8.0`
* `GuppyModule.load` no longer loads the content of modules but instead
just brings the name of the module into scope. Use
`GuppyModule.load_all` to get the old behaviour.
* Removed `guppylang.hugr_builder.hugr.Hugr`, compiling a module returns
a `hugr.Package` instead.

### Features

* Add `__version__` field to guppylang
([#473](#473))
([b996c62](b996c62))
* Add angle type ([#449](#449))
([12e41e0](12e41e0))
* Add array literals
([#446](#446))
([a255c02](a255c02))
* Add equality test for booleans
([#394](#394))
([dd702ce](dd702ce)),
closes [#363](#363)
* Add pi constant ([#451](#451))
([9d35a78](9d35a78))
* Add qualified imports and make them the default
([#443](#443))
([553ec51](553ec51))
* Allow calling of methods
([#440](#440))
([5a59da3](5a59da3))
* Allow imports of function definitions and aliased imports
([#432](#432))
([e23b666](e23b666))
* Array indexing ([#415](#415))
([2199b48](2199b48)),
closes [#421](#421)
[#422](#422)
[#447](#447)
* Inout arguments ([#311](#311))
([060649b](060649b)),
closes [#315](#315)
[#316](#316)
[#349](#349)
[#344](#344)
[#321](#321)
[#331](#331)
[#350](#350)
[#340](#340)
[#351](#351)
* range() with single-argument
([#452](#452))
([d05f369](d05f369))
* Skip checking of redefined functions
([#457](#457))
([7f9ad32](7f9ad32))
* Support `nat`/`int` ↔ `bool` cast operations
([#459](#459))
([3b778c3](3b778c3))
* Use `hugr-cli` for validation
([#455](#455))
([1d0667b](1d0667b))
* Use cell name instead of file for notebook errors
([#382](#382))
([d542601](d542601))
* Use the hugr builder
([536abf9](536abf9))


### Bug Fixes

* Fix and update demo notebook
([#376](#376))
([23b2a15](23b2a15))
* Fix linearity checking bug
([#441](#441))
([0b8ea21](0b8ea21))
* Fix struct definitions in notebooks
([#374](#374))
([b009465](b009465))


### Documentation

* Update readme, `cargo build` instead of `--extra validation`
([#471](#471))
([c2a4c86](c2a4c86))


### Miscellaneous Chores

* Update hugr to `0.8.0`
([#454](#454))
([b02e0d0](b02e0d0))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@hugrbot hugrbot mentioned this pull request Oct 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doug-q doug-q doug-q approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support ifrombool / itobool for arbitrary ints Converting bool to int doesn't work
4 participants
@aborgna-q @codecov-commenter @qartik @doug-q