fix!: Use latest results extension spec #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #370 +/- ##
==========================================
- Coverage 91.42% 91.32% -0.10%
==========================================
Files 47 47
Lines 5249 5294 +45
==========================================
+ Hits 4799 4835 +36
- Misses 450 459 +9 ☔ View full report in Codecov by Sentry. |
ss2165
reviewed
Aug 12, 2024
Comment on lines
+304
to
+305
| assert isinstance(ty_arg, TypeArg) | ||
| assert isinstance(len_arg, ConstArg) |
There was a problem hiding this comment.
can these asserts result in unhelpful errors?
There was a problem hiding this comment.
No, failing asserts would be a compiler bug since you shouldn't be able to construct an array type with invalid args
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 12, 2024
🤖 I have created a release *beep* *boop* --- ## [0.9.0](v0.8.1...v0.9.0) (2024-08-12) ### ⚠ BREAKING CHANGES * ### Bug Fixes * Use latest results extension spec ([#370](#370)) ([d9cc8d2](d9cc8d2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #369 and fixes #365.
Make Guppy conform with the latest results spec introduced in CQCL/tket2#494
BREAKING CHANGE: