Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Ignore tests and scripts in codecov report #153

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Conversation

mark-koch
Copy link
Collaborator

No description provided.

@mark-koch mark-koch changed the title ci: Ignore tests in scripts in codecov report ci: Ignore tests and scripts in codecov report Mar 4, 2024
@aborgna-q
Copy link
Collaborator

Uhm, it didn't ignore the directories in
https://app.codecov.io/gh/CQCL/guppylang/tree/ci%2Fcodecov-ignore

@mark-koch mark-koch merged commit f78fcd0 into main Mar 4, 2024
4 checks passed
@mark-koch mark-koch deleted the ci/codecov-ignore branch March 4, 2024 15:44
@mark-koch
Copy link
Collaborator Author

Oops clicked merge too early

@mark-koch
Copy link
Collaborator Author

Mhmm any idea why it doesn't work? The yaml appears to be valid:

> curl --data-binary @codecov.yml https://codecov.io/validate

Valid!

{
  "ignore": [
    "^tests.*",
    "^scripts.*"
  ]
}

@aborgna-q
Copy link
Collaborator

nvm, it works on main
https://app.codecov.io/gh/CQCL/guppylang

Probably codecov only reads the config from the default branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants