feat: Allow lists in py expressions #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-koch
force-pushed
the
feat/py-lists
branch
from
6de5059 to
f0435e7
Compare
croyzor
reviewed
Jan 25, 2024
croyzor
reviewed
Jan 25, 2024
croyzor
reviewed
Jan 25, 2024
| node, | ||
| ) from e | ||
|
|
||
| python_val = eval_py_expr(node, self.ctx) | ||
| if ty := python_value_to_guppy_type(python_val, node, self.ctx.globals): |
There was a problem hiding this comment.
I don't understand why we're converting python_val to a type. It's an arbitrary python value right? Just something inside a py(...)?
There was a problem hiding this comment.
Okay, I'm looking up how python match works...
There was a problem hiding this comment.
Here, we're checking that the Python expression inside py(...) evaluates to something that is valid in Guppy and compute the corresponding Guppy type
croyzor
reviewed
Jan 25, 2024
| @@ -67,6 +74,11 @@ def float_value(f: float) -> val.Value: | |||
| return val.ExtensionVal(c=(ConstF64(value=f),)) | |||
|
|
|||
|
|
|||
| def list_value(v: list[val.Value]) -> val.Value: | |||
| """Returns the Hugr representation of a list value.""" | |||
| return val.ExtensionVal(c=(ListValue(value=v),)) | |||
There was a problem hiding this comment.
(x,) is a unary tuple. We need this because of some serialisation shenanigans...
croyzor
approved these changes
Jan 30, 2024
This was referenced Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #114