Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load pytket functions without explicit function stub #670

Closed
tatiana-s opened this issue Nov 29, 2024 · 0 comments · Fixed by #712
Closed

Load pytket functions without explicit function stub #670

tatiana-s opened this issue Nov 29, 2024 · 0 comments · Fixed by #712
Assignees

Comments

@tatiana-s
Copy link
Contributor

See #657 for initial issue.

Add a load_pytket method. One complication here is finding the call location for error reporting (see _parse_expr_string for extern method which does something similar).

@tatiana-s tatiana-s self-assigned this Nov 29, 2024
github-merge-queue bot pushed a commit that referenced this issue Dec 6, 2024
Closes #657, however the following limitations still exist which are
covered by further issues:
- #669: ~~Classical bits and measurements aren't currently supported as
this requires some checks related to ownership and return values.~~ They
are supported but without taking ownership.
- #670: It would be nice to not have to provide an explicit function
stub for the circuit and also have `load_pytket` method which infers it.
- #671: It would also be nice to be able to provide arrays of qubits in
the function stub.
github-merge-queue bot pushed a commit that referenced this issue Dec 16, 2024
Closes #670 

Both finding the call location and then having either a node or a span
for errors feels a bit hacky but I haven't been able to think of
something better so far and it seems to work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant