Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Known-size array unpacking #649

Closed
ss2165 opened this issue Nov 15, 2024 · 1 comment · Fixed by #688
Closed

Known-size array unpacking #649

ss2165 opened this issue Nov 15, 2024 · 1 comment · Fixed by #688
Assignees
@mark-koch
Milestone
guppylang 0.14.0

Comments

@ss2165
Copy link
Member

ss2165 commented Nov 15, 2024

When array sizes are known (and not generic) allow things like:

qs = array(qubit(), qubit())
[q0, q1] = qs
[q0, *_] = qs
[*_, q_prev, q_last]
@mark-koch mark-koch self-assigned this Nov 28, 2024
@mark-koch
Copy link
Collaborator

In fact, we should allow this for all SizedIter types!

This was referenced Dec 4, 2024
Merged
Merged
Open
@mark-koch mark-koch added this to the guppylang 0.14.0 milestone Dec 9, 2024
mark-koch added a commit that referenced this issue Dec 17, 2024
@mark-koch
feat: Lower unpacking assignment of iterables to Hugr (#689)
3262031 
Adds the Hugr lowering for #649. See #688 for the base PR that adds the
checking logic
github-merge-queue bot pushed a commit that referenced this issue Dec 17, 2024
@mark-koch
feat: Unpacking assignment of iterable types with static size (#688)
602e243 
Closes #649.

Sorry for the big PR, but there was no good way to split the checking
logic up. I recommend reviewing commit by commit, most of the actual
logic is in 616c0c5. Hugr lowering follows in a separate PR (#689).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mark-koch mark-koch

Labels
None yet
Projects
None yet
Milestone
guppylang 0.14.0
Development

Successfully merging a pull request may close this issue.

feat: Unpacking assignment of iterable types with static size CQCL/guppylang
2 participants
@ss2165 @mark-koch