feat: Add missing tket2 quantum gates, generalise RotationCompile #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jake-arkinstall
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #510 +/- ##
==========================================
- Coverage 91.67% 91.58% -0.10%
==========================================
Files 59 59
Lines 6138 6166 +28
==========================================
+ Hits 5627 5647 +20
- Misses 511 519 +8 ☔ View full report in Codecov by Sentry. |
mark-koch
reviewed
Sep 23, 2024
| [q, angle] = args | ||
| qs, angle = args[:-1], args[-1] |
There was a problem hiding this comment.
Suggested change
| [q, angle] = args | |
| qs, angle = args[:-1], args[-1] | |
| [*qs, angle] = args |
Comment on lines
+39
to
+40
| @guppy.hugr_op(quantum_op("CY")) | ||
| def cy(control: qubit, target: qubit) -> None: ... |
There was a problem hiding this comment.
Can you also add these functions to the quantum_functional module?
Co-authored-by: Mark Koch <[email protected]>
mark-koch
approved these changes
Sep 23, 2024
ss2165
deleted the
484-add-missing-tket2quantum-operations-to-quantum-module
branch
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 23, 2024
🤖 I have created a release *beep* *boop* --- ## [0.12.1](v0.12.0...v0.12.1) (2024-09-23) ### Features * Add Definition.compile producing Hugr Package ([#504](#504)) ([d8c8bec](d8c8bec)) * Add missing tket2 quantum gates, generalise RotationCompile ([#510](#510)) ([18d4b4c](18d4b4c)) ### Miscellaneous Chores * release 0.12.1 ([#512](#512)) ([b309a94](b309a94)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #484