Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing tket2.quantum operations to quantum module #484

Closed
ss2165 opened this issue Sep 11, 2024 · 2 comments · Fixed by #510
Closed

Add missing tket2.quantum operations to quantum module #484

ss2165 opened this issue Sep 11, 2024 · 2 comments · Fixed by #510
Labels
enhancement New feature or request
Milestone
guppylang 0.11.1

Comments

@ss2165
Copy link
Member

ss2165 commented Sep 11, 2024 

          see Tk2ops, we should add missing (I can see at least Ry, CRz, Toffoli missing)

Originally posted by @ss2165 in #483 (comment)
@ss2165 ss2165 added the enhancement New feature or request label Sep 11, 2024
@ss2165 ss2165 added this to the guppylang 0.11.1 milestone Sep 11, 2024
@ss2165 ss2165 changed the title Add missing tket.quantum operations to quantum module Add missing tket2.quantum operations to quantum module Sep 11, 2024
@jake-arkinstall
Copy link
Contributor

Any chance of rushing this in on Monday? Could do with it for the notebooks (specifically crz, possibly others)

@jake-arkinstall
Copy link
Contributor

I'll give it a go now

@jake-arkinstall jake-arkinstall linked a pull request Sep 23, 2024 that will close this issue
feat: Add missing tket2 quantum gates, generalise RotationCompile #510
Merged
@jake-arkinstall jake-arkinstall mentioned this issue Sep 23, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 23, 2024
@jake-arkinstall @mark-koch
feat: Add missing tket2 quantum gates, generalise RotationCompile (#510)
18d4b4c 
Addresses #484

---------

Co-authored-by: Mark Koch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
guppylang 0.11.1
Development

Successfully merging a pull request may close this issue.

feat: Add missing tket2 quantum gates, generalise RotationCompile CQCL/guppylang
2 participants
@ss2165 @jake-arkinstall