Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hseries op compilation is broken #477

Closed
ss2165 opened this issue Sep 11, 2024 · 0 comments · Fixed by #483 or #474
Closed

Hseries op compilation is broken #477

ss2165 opened this issue Sep 11, 2024 · 0 comments · Fixed by #483 or #474
Assignees
@aborgna-q
Labels
bug Something isn't working
Milestone
guppylang 0.11.0

Comments

@ss2165
Copy link
Member

ss2165 commented Sep 11, 2024

Angles need to be converted to floats before being passed to "tket2.hseries" ops.
@ss2165 ss2165 added the bug Something isn't working label Sep 11, 2024
@ss2165 ss2165 added this to the guppylang 0.11.0 milestone Sep 11, 2024
@aborgna-q aborgna-q self-assigned this Sep 11, 2024
@aborgna-q aborgna-q mentioned this issue Sep 11, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 11, 2024
@aborgna-q
fix: hseries ops use floats instead of angles (#483)
7ed3853 
Adds unit tests to generate and validate each operation in
`prelude.quantum`.

Closes #477
@hugrbot hugrbot mentioned this issue Sep 11, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 11, 2024
@hugrbot
chore(main): release 0.11.0 (#474)
5cfcdf5 
🤖 I have created a release *beep* *boop*
---


## [0.11.0](v0.10.0...v0.11.0)
(2024-09-11)


### ⚠ BREAKING CHANGES

* `guppy.take_module` renamed to `guppy.get_module` and no longer
removes the module from the state.
* Quantum operations `rx`, `rz`, `phased_x`, and `zz_max` use the
`angle` type instead of floats.

### Features

* Add implicit importing of modules
([#461](#461))
([1b73032](1b73032))
* Use angle type in quantum operations
([#467](#467))
([ce0f746](ce0f746))


### Bug Fixes

* hseries ops use floats instead of angles
([#483](#483))
([7ed3853](7ed3853)),
closes [#477](#477)
* Keep track of definitions that are implicitly imported
([#481](#481))
([a89f225](a89f225)),
closes [#480](#480)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@hugrbot hugrbot mentioned this issue Oct 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborgna-q aborgna-q

Labels
bug Something isn't working
Projects
None yet
Milestone
guppylang 0.11.0
2 participants
@ss2165 @aborgna-q