Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rethink the import system #134

Closed
mark-koch opened this issue Jan 24, 2024 · 0 comments · Fixed by #432
Closed

Rethink the import system #134

mark-koch opened this issue Jan 24, 2024 · 0 comments · Fixed by #432
Labels
enhancement New feature or request

Comments

@mark-koch
Copy link
Collaborator

  • qualified/unqualified?
  • open/closed?
  • renaming?
@mark-koch mark-koch added the enhancement New feature or request label Jan 24, 2024
@mark-koch mark-koch mentioned this issue Feb 2, 2024
Closed
@mark-koch mark-koch mentioned this issue Aug 30, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 2, 2024
@mark-koch
feat: Allow imports of function definitions and aliased imports (#432)
e23b666 
Closes #425 and closes #427 and closes #134

* Allow importing of function definitions (before we could only import
declarations)
* Until we have Hugr linking, we just lower everything into the same
Hugr. This requires some changes to the compilation logic:
- Differentiate between checking (`module.check()`) and full Hugr
compilation (`module.compile()`) of modules
  - Importing modules only checks them
- Hugr lowering is done at the end in one step over all imported modules
* Allow to import individual definitions instead of whole modules
* Allow aliased imports using kwargs (see test examples)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@mark-koch