Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use pyfftw for FFT #363

Merged
merged 1 commit into from
Oct 30, 2018
Merged

use pyfftw for FFT #363

merged 1 commit into from
Oct 30, 2018

Conversation

superbock
Copy link
Collaborator

@superbock superbock commented Apr 17, 2018

Changes proposed in this pull request

Use pyfftw (if available) to compute FFT. Gives up to 40% faster FFT computation.

@superbock
Copy link
Collaborator Author

superbock commented Apr 18, 2018

I think it is save to merge, since Travis uses the new pyfftw code, whereas Appveyor doesn't (there were some problems installing pyfftw on Windows). So we have both code paths covered. Probably there's a better way to test both, but I think this suffices for now.

@superbock superbock changed the base branch from python_37 to master October 18, 2018 14:28
@superbock superbock requested a review from fdlm October 19, 2018 08:07
Copy link
Contributor

@fdlm fdlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@superbock superbock merged commit e3f8599 into master Oct 30, 2018
@superbock superbock deleted the fftw branch October 30, 2018 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants