Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linear-Chain CRF implementation #144

Merged
merged 2 commits into from
Jun 29, 2016
Merged

Linear-Chain CRF implementation #144

merged 2 commits into from
Jun 29, 2016

Conversation

fdlm
Copy link
Contributor

@fdlm fdlm commented Jun 29, 2016

No description provided.

@coveralls
Copy link

coveralls commented Jun 29, 2016

Coverage Status

Coverage increased (+0.03%) to 92.909% when pulling e677114 on feature/crf into 7076096 on master.

@codecov-io
Copy link

codecov-io commented Jun 29, 2016

Current coverage is 92.90%

Merging #144 into master will increase coverage by 0.03%

@@             master       #144   diff @@
==========================================
  Files            64         66     +2   
  Lines         11006      11058    +52   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          10221      10273    +52   
  Misses          785        785          
  Partials          0          0          

Powered by Codecov. Last updated by 7076096...450ef93

@coveralls
Copy link

coveralls commented Jun 29, 2016

Coverage Status

Coverage increased (+0.03%) to 92.909% when pulling 181d044 on feature/crf into 7076096 on master.


def process(self, observations):
"""
Determine the most probable configuration of Y (state sequence given X:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

) at end of line is missing

@superbock
Copy link
Collaborator

Thanks, Sphinx documentation is missing though.

A simple docs/modules/ml/crf.rst file containing

madmom.ml.crf
=============

.. automodule:: madmom.ml.crf
    :members:

and an additional line with ml/crf in docs/modules/ml.rst should suffice.

@coveralls
Copy link

coveralls commented Jun 29, 2016

Coverage Status

Coverage increased (+0.03%) to 92.909% when pulling 450ef93 on feature/crf into 7076096 on master.

@superbock superbock merged commit 8858d2d into master Jun 29, 2016
@superbock superbock deleted the feature/crf branch June 29, 2016 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants