-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed C dependency from binary exporter #395
Removed C dependency from binary exporter #395
Conversation
Looks pretty good to me, would be great to remove that dependency 👍 |
@SebastianSchildt - now there are conflicts |
Signed-off-by: Sebastian Schildt <[email protected]>
Signed-off-by: Sebastian Schildt <[email protected]>
Signed-off-by: Sebastian Schildt <[email protected]>
Signed-off-by: Sebastian Schildt <[email protected]>
a5130ce
to
30ac48d
Compare
Signed-off-by: Sebastian Schildt <[email protected]>
Rebased. Added some additional make-up to pass our new ruff bouncer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
@UlfBj - could you check if output is compatible |
MoM:
|
I did a test on my Debian AMD64 VM comparing the output generated by this PR and latest master and the files were identical. @UlfBj - what type of errors did you experience. Was it in generating the binary file, or that the binary file seems to be faulty? If it is latter case how can one try to reproduce it? |
To me it seems that the build problems that Ulf experience is unrelated to this PR itself as he experience them also for master branch. I tested with a virgin Debian VM and did not experience any build problems, and the output generated with/without this PR was identical. Suggest merge decision at the meeting tonight |
MoM:
|
This removes the C dependency from the binary, making it pure Python.
That would make it also usable when installing the Pypi packages without compiling any additional dll
@UlfBj can you check this works for you? Only changes are in vss2binary.py