Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give error if unit is used for branch or struct #304

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

erikbosch
Copy link
Collaborator

We do not list unit as an allowed keyword for branches in our documentation. However, as of today we do not check that. This PR addresses that.

@erikbosch erikbosch marked this pull request as draft October 31, 2023 15:00
@erikbosch
Copy link
Collaborator Author

Found some more unit-related parts that better should be improved as part of this PR

@erikbosch erikbosch added the Status:Rework Committer must refactor or address comments label Oct 31, 2023
@erikbosch erikbosch added Status:Review Please review/discuss contents and removed Status:Rework Committer must refactor or address comments labels Nov 1, 2023
@erikbosch erikbosch marked this pull request as ready for review November 1, 2023 09:31
@erikbosch erikbosch merged commit fa2fd44 into COVESA:master Nov 7, 2023
6 checks passed
@erikbosch erikbosch deleted the erik_unit branch November 7, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Review Please review/discuss contents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant