Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add data point Wheel.Speed #464

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

jdacoello
Copy link
Contributor

As mentioned in issue #368, there are datasets that use that data point.

Speed:
datatype: float
type: sensor
unit: km/h
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is km/h a "good" unit for wheel speed. (and does it match description?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sensing system measures how fast the wheel rotates. From the sensor point of view, the unit would be something like radians/second or degrees/second. I believe that in a vehicle, however, this signal is used to derive the vehicle's speed. Since VSS does not describe the sensor itself, but rather focuses on the characteristic that the data is supposed to describe, the unit should be the same as the one used for the speed of the vehicle (i.e., km/h).

In the dataset example, the unit of this data is measured in m/s. Similarly, vendors specify the sensitivity of the sensor in km/h (See, for example this one that says "Speed detection close to 0.1 km/h").

@SebastianSchildt
Copy link
Collaborator

Decision to merge July 27th 2022

@SebastianSchildt SebastianSchildt merged commit 2a94134 into COVESA:master Jul 26, 2022
@erikbosch erikbosch mentioned this pull request Aug 10, 2022
@jdacoello jdacoello deleted the wheel-speed branch May 3, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants