Fix return value of dlt_log_init function #711
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
margopodvig
approved these changes
Dec 6, 2024
|
Please consider to rework, should change code snipe inside issue function, not the dlt_log_init itself |
minminlittleshrimp
requested changes
Dec 6, 2024
src/shared/dlt_log.c
Outdated
| @@ -77,7 +77,7 @@ void dlt_log_set_level(int level) | |||
| } | |||
| } | |||
|
|
|||
| void dlt_log_init(int mode) | |||
| DltReturnValue dlt_log_init(int mode) | |||
There was a problem hiding this comment.
dlt_log_init must not return anything since it is a void call.
There was a problem hiding this comment.
Hello @minminlittleshrimp ,
could you explain why that function must not return anything?
There was a problem hiding this comment.
is there any impacts when we set return value for that function?
|
Hello @Le-Tin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dlt_log_init function should return with value