Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add functionality to dump ring buffer to disk file #580

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jianjun-huang
Copy link

For example:
/usr/bin/dlt-logstorage-ctrl -D /tmp/ss.dlt

will dump the entries in ringbuffer to file /tmp/ss.dlt

For example:
/usr/bin/dlt-logstorage-ctrl -D /tmp/ss.dlt

will dump the entries in ringbuffer to file /tmp/ss.dlt
@minminlittleshrimp
Copy link
Collaborator

Hello @jianjun-huang
thanks for your contribution, this looks interesting feature for dlt.
Dumping logs from ring buffer to files would be very useful in case no daemon available and we need to rotate the buffer for new logs. This prevents missing all the old logs.
I will review and test on my local.
Regards

@minminlittleshrimp
Copy link
Collaborator

Hello @jianjun-huang
I read through the code change and it seems the same functionality of our current implementation of Sync Behavior ON_DEMAND: When activate this sync option, we just need to send a sync signal for dumping logs from cache (logstorage ring buffer) to dlt files.
Could you kindly clarify my point?
In this case, we will reconsider to not approve for this PR.
Regards

@jianjun-huang
Copy link
Author

Hi @minminlittleshrimp
this option is similar to ON_DEMAND, but this option does not remove logs from ringbuffer, just peek dlt messages from the ringbuffer.

@minminlittleshrimp
Copy link
Collaborator

I see, I need to check in my local. So sorry for the late response, we are busy these days releasing internal dlt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants