Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/backend/book room(occupi id generator) #77

Merged
merged 7 commits into from
Jun 21, 2024

Conversation

Rethakgetse-Manaka
Copy link
Contributor

Description

Bookings model is updated

Fixes # (issue)

Type of change

Updated booking to and included a generateID
type Booking struct {
ID string json:"_id" bson:"_id,omitempty"
OccupiID string json:"occupiId" bson:"occupiId,omitempty"
RoomID string json:"roomId" bson:"roomId"
RoomName string json:"roomName" bson:"roomName,omitempty"
Slot int json:"slot" bson:"slot"
Emails []string json:"emails" bson:"emails"
CheckedIn bool json:"checkedIn" bson:"checkedIn,omitempty"
Creator string json:"creator" bson:"creator"
FloorNo int json:"floorNo" bson:"floorNo"
Date time.Time json:"date" bson:"date,omitempty"
Start time.Time json:"start" bson:"start,omitempty"
End time.Time json:"end" bson:"end,omitempty"
}

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.21%. Comparing base (c042f22) to head (8503430).
Report is 3 commits behind head on develop.

Files Patch % Lines
occupi-backend/pkg/utils/utils.go 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #77      +/-   ##
===========================================
+ Coverage    67.09%   67.21%   +0.12%     
===========================================
  Files            5        5              
  Lines          234      241       +7     
===========================================
+ Hits           157      162       +5     
- Misses          68       69       +1     
- Partials         9       10       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rethakgetse-Manaka Rethakgetse-Manaka marked this pull request as draft June 21, 2024 13:28
@Rethakgetse-Manaka Rethakgetse-Manaka marked this pull request as ready for review June 21, 2024 14:28
@Rethakgetse-Manaka Rethakgetse-Manaka merged commit 7ef7c04 into develop Jun 21, 2024
6 checks passed
@Rethakgetse-Manaka Rethakgetse-Manaka deleted the fix/backend/BookRoom(OccupiID-Generator) branch June 21, 2024 14:29
@Rethakgetse-Manaka Rethakgetse-Manaka restored the fix/backend/BookRoom(OccupiID-Generator) branch June 21, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant