Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bringing changes downstream #426

Merged
merged 6 commits into from
Oct 20, 2024
Merged

Bringing changes downstream #426

merged 6 commits into from
Oct 20, 2024

Conversation

waveyboym
Copy link
Member

Description

Bringing changes downstream

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Rethakgetse-Manaka and others added 6 commits October 18, 2024 20:31
…Worker-Dashboard

Fixes/web/overviewer and worker dashboard
…tion and to only check for 200 response from ping-admin endpoint
Refactor AuthService to return full response object in pingAdmin function and to only check for 200 response from ping-admin endpoint
@waveyboym waveyboym added the type: bringing changes downstream Just bringing changes downstream label Oct 20, 2024
@waveyboym waveyboym added this to the PROJECT DAY🎉🎨 milestone Oct 20, 2024
@waveyboym waveyboym self-assigned this Oct 20, 2024
@waveyboym waveyboym merged commit f23dbfe into QC/web/ip-address-revamp Oct 20, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bringing changes downstream Just bringing changes downstream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants