Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/web/recommendations #404

Merged
merged 4 commits into from
Sep 26, 2024
Merged

Conversation

Rethakgetse-Manaka
Copy link
Contributor

Description

Added recommendations modal
Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Rethakgetse-Manaka Rethakgetse-Manaka added type: feature A new feature priority: medium This does/did not need to be addressed soon but should have plans in place to be addressed effort: 5 This may require/required hours of work platform: web/desktop This is related to web/desktop platforms For: deployment This will affect our deployed system For: integration This is for work involving integration with the backend/model API labels Sep 26, 2024
@Rethakgetse-Manaka Rethakgetse-Manaka self-assigned this Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.78%. Comparing base (11d8e2f) to head (47a9a7c).
Report is 5 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (11d8e2f) and HEAD (47a9a7c). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (11d8e2f) HEAD (47a9a7c)
3 1
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #404       +/-   ##
============================================
- Coverage    85.93%   42.78%   -43.15%     
============================================
  Files           40       18       -22     
  Lines         4414      416     -3998     
  Branches        84        0       -84     
============================================
- Hits          3793      178     -3615     
+ Misses         530      238      -292     
+ Partials        91        0       -91     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rethakgetse-Manaka Rethakgetse-Manaka merged commit b5034af into develop Sep 26, 2024
5 of 7 checks passed
@Rethakgetse-Manaka Rethakgetse-Manaka deleted the feature/Web/Recommendations branch September 26, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: 5 This may require/required hours of work For: deployment This will affect our deployed system For: integration This is for work involving integration with the backend/model API platform: web/desktop This is related to web/desktop platforms priority: medium This does/did not need to be addressed soon but should have plans in place to be addressed type: feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant