Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/web/general polishing up #402

Merged
merged 6 commits into from
Sep 26, 2024
Merged

Conversation

Tinashe-Austin
Copy link
Contributor

@Tinashe-Austin Tinashe-Austin commented Sep 26, 2024

Description

Web fixes

Fixes #401

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Tinashe-Austin Tinashe-Austin added type: chore Just a cleanup or minor update type: feature A new feature type: fix Introduces a fix for a previous issue For: frontend This is mainly related to frontend UI code priority: medium This does/did not need to be addressed soon but should have plans in place to be addressed effort: 5 This may require/required hours of work platform: web/desktop This is related to web/desktop platforms For: integration This is for work involving integration with the backend/model API labels Sep 26, 2024
@Tinashe-Austin Tinashe-Austin self-assigned this Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 10.52632% with 17 lines in your changes missing coverage. Please review.

Project coverage is 42.78%. Comparing base (83fc7ea) to head (42d9956).
Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
frontend/occupi-web/src/assets/icons/Employee.tsx 10.52% 17 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (83fc7ea) and HEAD (42d9956). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (83fc7ea) HEAD (42d9956)
3 1
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #402       +/-   ##
============================================
- Coverage    86.93%   42.78%   -44.16%     
============================================
  Files           39       18       -21     
  Lines         4395      416     -3979     
  Branches        84        0       -84     
============================================
- Hits          3821      178     -3643     
+ Misses         514      238      -276     
+ Partials        60        0       -60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tinashe-Austin Tinashe-Austin merged commit ee3d0ee into develop Sep 26, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: 5 This may require/required hours of work For: frontend This is mainly related to frontend UI code For: integration This is for work involving integration with the backend/model API platform: web/desktop This is related to web/desktop platforms priority: medium This does/did not need to be addressed soon but should have plans in place to be addressed type: chore Just a cleanup or minor update type: feature A new feature type: fix Introduces a fix for a previous issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK]Fixes for web
1 participant