Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/web/protected routes fix #308

Merged
merged 5 commits into from
Aug 14, 2024
Merged

Conversation

Rethakgetse-Manaka
Copy link
Contributor

Description

Implemented protected routes. Now you can't go to login page if you're logged in

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Rethakgetse-Manaka Rethakgetse-Manaka added For: frontend This is mainly related to frontend UI code effort: 3 This can be/was resolved in minutes be requires/required deep engagement effort: 5 This may require/required hours of work For: deployment This will affect our deployed system labels Aug 14, 2024
@Rethakgetse-Manaka Rethakgetse-Manaka self-assigned this Aug 14, 2024
@Rethakgetse-Manaka Rethakgetse-Manaka merged commit 294fe19 into develop Aug 14, 2024
4 checks passed
@Rethakgetse-Manaka Rethakgetse-Manaka deleted the fix/web/protectedRoutes-fix branch August 14, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: 3 This can be/was resolved in minutes be requires/required deep engagement effort: 5 This may require/required hours of work For: deployment This will affect our deployed system For: frontend This is mainly related to frontend UI code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant