Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/mobile/login flow #169

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Fix/mobile/login flow #169

merged 3 commits into from
Jul 9, 2024

Conversation

KamogeloMoeketse
Copy link
Contributor

Description

Login on mobile now stores the token received upon a successful login in expo's encyrypted secure storage. When making requests in future, this token is retrieved and sent with the request as the auth header. This solves the problem on the login, logout issue for mobile.

Fixes #168

Type of change Fix

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@KamogeloMoeketse KamogeloMoeketse merged commit ade67e2 into develop Jul 9, 2024
2 of 3 checks passed
@KamogeloMoeketse KamogeloMoeketse deleted the fix/mobile/login-flow branch July 9, 2024 22:06
@KamogeloMoeketse KamogeloMoeketse mentioned this pull request Jul 17, 2024
12 tasks
waveyboym pushed a commit that referenced this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIX] login flow for mobile
1 participant