Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor email sending to skip sending emails in test mode #150

Merged
merged 3 commits into from
Jul 6, 2024

Conversation

waveyboym
Copy link
Member

@waveyboym waveyboym commented Jul 4, 2024

Description

This pr is just moving code and adding some guard checks

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Ensuring all previously running tests still run

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@waveyboym waveyboym added type: fix Introduces a fix for a previous issue type: testing This affects one or more tests For: api This is mainly for the api For: backend This is mainly for the backend code effort: 2 This can be/was resolved in minutes but requires/required shallow engagement labels Jul 4, 2024
@waveyboym waveyboym added this to the Week 1 Sprint 3 milestone Jul 4, 2024
@waveyboym waveyboym self-assigned this Jul 4, 2024
@waveyboym waveyboym linked an issue Jul 4, 2024 that may be closed by this pull request
1 task
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.85%. Comparing base (95a6887) to head (0fc1302).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #150   +/-   ##
========================================
  Coverage    85.85%   85.85%           
========================================
  Files            5        5           
  Lines          304      304           
========================================
  Hits           261      261           
  Misses          31       31           
  Partials        12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waveyboym waveyboym merged commit 6e48460 into develop Jul 6, 2024
6 checks passed
@waveyboym waveyboym deleted the test/backend/integration-test-auth-handlers branch July 6, 2024 17:45
waveyboym added a commit that referenced this pull request Aug 12, 2024
…test-auth-handlers

chore: Refactor email sending to skip sending emails in test mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: 2 This can be/was resolved in minutes but requires/required shallow engagement For: api This is mainly for the api For: backend This is mainly for the backend code type: fix Introduces a fix for a previous issue type: testing This affects one or more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Integration test auth handlers
1 participant