Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update cookie expiration time to use time.Until() instead of int(expirationTime.Unix()) #108

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

waveyboym
Copy link
Member

@waveyboym waveyboym commented Jun 27, 2024

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)
#107

Type of change

Addresses an issue whereby tokens being generated had falsely advertised expiry date of +54 years from now().

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tested in postman to ensure the introduced changes took effect and observed that they did

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@waveyboym waveyboym added For: api This is mainly for the api For: backend This is mainly for the backend code effort: 1 This can be/was resolved in minutes labels Jun 27, 2024
@waveyboym waveyboym added this to the Stability Run milestone Jun 27, 2024
@waveyboym waveyboym linked an issue Jun 27, 2024 that may be closed by this pull request
@waveyboym waveyboym self-assigned this Jun 27, 2024
@waveyboym waveyboym merged commit 01d419f into develop Jun 27, 2024
4 checks passed
@waveyboym waveyboym deleted the fix/backend/token-expiry-date-issue branch June 27, 2024 21:01
waveyboym added a commit that referenced this pull request Aug 12, 2024
…date-issue

chore: Update cookie expiration time to use time.Until() instead of int(expirationTime.Unix())
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: 1 This can be/was resolved in minutes For: api This is mainly for the api For: backend This is mainly for the backend code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Generated tokens seem to have expiry time of 100 years
1 participant