Re-added features from file-Upload-Pipe #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JBlixems
requested changes
Jul 12, 2024
There was a problem hiding this comment.
Please just look at the file structure again.
Routes folder is only for any express routes, you can add another file for uploads.js routes.
Then put the pipe inside the lib since it does not have any express routes.
Then finally just add the necessary line for the pipe routes in the index
JBlixems
requested changes
Jul 12, 2024
server/routes/pipe.js
Outdated
| @@ -0,0 +1,64 @@ | |||
|
|
|||
|
|
|||
| const handleFileUpload = async (req, res, pgClient, vaId) => { | |||
There was a problem hiding this comment.
Rather import pgClient than send it through a parameter
JBlixems
reviewed
Jul 12, 2024
| <Paper elevation={3} sx={{ padding: 2, marginTop: 2 }}> | ||
| <List> | ||
| {users.map(user => ( | ||
| <ListItem key={user.user_id} sx={{ marginBottom: 1, padding: 1, borderRadius: 1, boxShadow: 1 }}> |
There was a problem hiding this comment.
Can you display some text informing the user if they have no clients assigned to them
JBlixems
requested changes
Jul 12, 2024
- fixed font color - added a message if no clients or orgs have been asigned
- fixed unit tests (pls)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added ability for VA to upload and remove files to assigned clients and organisations.