Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/e2etests #59

Closed
wants to merge 28 commits into from
Closed

Fix/e2etests #59

wants to merge 28 commits into from

Conversation

JBlixems
Copy link
Contributor

@JBlixems JBlixems commented Jul 2, 2024

Description

Fixed the e2e tests and cached the npm packages in other workflows so they are faster

Copy link

gitguardian bot commented Jul 2, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11946661 Triggered Generic Password 216c35c .github/workflows/e2e.yml View secret
11946661 Triggered Generic Password 82a24f2 .github/workflows/e2e.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@JBlixems JBlixems requested a review from Alec-Watson July 2, 2024 09:51
@JBlixems JBlixems closed this Jul 2, 2024
@JBlixems JBlixems deleted the fix/e2etests branch July 3, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant