Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating UX/UI #284

Open
wants to merge 98 commits into
base: develop
Choose a base branch
from
Open

Updating UX/UI #284

wants to merge 98 commits into from

Conversation

jademichellepeche
Copy link
Collaborator

No description provided.

Thivesshj and others added 30 commits September 3, 2022 14:04
still need to intergrate
fixed with custom hooks
@gitguardian
Copy link

gitguardian bot commented Oct 26, 2022

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
4559397 Google API Key 5966d39 front-end/src/components/SelectGym-Map/SelectGymMap.tsx View secret
4559397 Google API Key 5966d39 front-end/src/components/SelectGym-Map/SelectGymMap.tsx View secret
4568650 Google API Key 7c342ea front-end/src/components/SelectGym-Map/SelectGymMap.tsx View secret
4568650 Google API Key 7c342ea front-end/src/components/SelectGym-Map/SelectGymMap.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 75 Code Smells

No Coverage information No Coverage information
17.7% 17.7% Duplication

@RyanBroemer RyanBroemer self-requested a review October 27, 2022 20:52
Copy link
Collaborator

@RyanBroemer RyanBroemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants