Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Drop python 2 support, add python 3.7 support #328

Closed
drewejohnson opened this issue Jul 27, 2019 · 0 comments · Fixed by #363
Closed

API Drop python 2 support, add python 3.7 support #328

drewejohnson opened this issue Jul 27, 2019 · 0 comments · Fixed by #363
Assignees
@drewejohnson
Labels
API - Incompatible Incompatible changes to our API that require user actions
Milestone
0.9.0

Comments

@drewejohnson
Copy link
Collaborator

Python 2 will be officially unsupported in 2020. Many packages have already transitioned to remove python 2 support. We should follow suit. I propose the following release schedule:

  1. Release 0.8.0 as the final release to include support for python 2.7.
  2. Release 0.9.0 should follow soon after with no API changes, but without python 2.7 features through the six module. We should also test against python 3.7.
@drewejohnson drewejohnson added Py - 2.7.x API - Incompatible Incompatible changes to our API that require user actions labels Jul 27, 2019
@drewejohnson drewejohnson added this to the 0.9.0 milestone Jul 27, 2019
@drewejohnson drewejohnson self-assigned this Jul 27, 2019
drewejohnson added a commit to drewejohnson/serpent-tools that referenced this issue Aug 31, 2019
@drewejohnson
TST Downgrade pytest version to support python 2.7
1770523 
Revert / readdress this commit once we move to python 3 only
with CORE-GATECH-GROUP#328
drewejohnson added a commit to drewejohnson/serpent-tools that referenced this issue Oct 4, 2019
@drewejohnson
DEV Add py2 compatibility for new Detectors
a1c114f 
- Remove all super calls in favor of directly calling the
  parent method
- Place Mappings in compatibility file

This can safely be reverted as a part of GH Issue CORE-GATECH-GROUP#328, when
python 2 support is removed
drewejohnson added a commit that referenced this issue Nov 17, 2019
@drewejohnson
DEV Add py2 compatibility for new Detectors
2e9089b 
- Remove all super calls in favor of directly calling the
  parent method
- Place Mappings in compatibility file

This can safely be reverted as a part of GH Issue #328, when
python 2 support is removed
@drewejohnson drewejohnson mentioned this issue Nov 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drewejohnson drewejohnson

Labels
API - Incompatible Incompatible changes to our API that require user actions
Projects
None yet
Milestone
0.9.0
Development

Successfully merging a pull request may close this issue.

API Remove python 2.7 support; Test and install against python 3.7 drewejohnson/serpent-tools
1 participant
@drewejohnson