Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installed "flow" in package.json and incorporated into github workflow #65

Open
wants to merge 4 commits into
base: f24
Choose a base branch
from

Conversation

J0nathanLai
Copy link

@J0nathanLai J0nathanLai commented Oct 29, 2024

This static analysis type checker tool "Flow" was not installed in the first checkpoint and has just been added as a tool we want to integrate.

In order to install flow, run npm install --save-dev flow-bin This will install the package flow into your project. You can see the changes inside the package.json file on line 164 where you will see "flow-bin": "^0.250.0" Inside the package.json file, add "flow": "flow"'to line 18 after the coveralls script.
Screenshot 2024-10-29 at 9 52 40 AM

The above steps would allow you to use the flow package locally.

Then to run this tool, run the command npm run flow init the first time you run this tool. This will generate the file .flowconfig which has been added to the files changed.
Screenshot 2024-10-29 at 9 55 34 AM

Then, run the command npm run flow which will actually check your code against the tool. Look for the "No errors!" line in the output.
Screenshot 2024-10-29 at 10 20 10 AM
We can see that there aren't any errors or warnings that the Flow tool is flagging.

Lastly, to integrate the tool into the workflow on Github, copy the code or the changes you made from package.json into install/package.json. This is because the Github workflow uses the packages from install/package.json. Then, go to .github/workflows/test.yaml and add the installation line and the run flow line.
Screenshot 2024-10-29 at 9 55 30 AM

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11565619047

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.002%) to 82.678%

Files with Coverage Reduction New Missed Lines %
src/meta/errors.js 1 76.74%
Totals Coverage Status
Change from base Build 11494762754: 0.002%
Covered Lines: 22332
Relevant Lines: 25591

💛 - Coveralls

@J0nathanLai J0nathanLai changed the title installed flow in package.json and incorporated into github workflow installed "flow" in package.json and incorporated into github workflow Oct 29, 2024
@J0nathanLai J0nathanLai self-assigned this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants